Prevent result duplication on slow search #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search logic happens in a timer, if a search is too slow than the configured delay, the same search will be performed again. This leads to the same results being appended again and again until the situation normalizes over time. To avoid this, we directly update the last term and page every time the search is processed instead of doing this after the search results where retrieved.
mbrodala
force-pushed
the
prevent-result-duplication
branch
from
2908252 to
3cbea28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search logic happens in a timer, if a search is too slow than the configured delay, the same search will be performed again.
This leads to the same results being appended again and again until the situation normalizes over time.
To avoid this, we directly update the last term and page every time the search is processed instead of doing this after the search results where retrieved.